Bugfix/cda 46 rating vertical datum #1355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanM-RMA
force-pushed
the
bugfix/CDA-46_rating_vertical_datum
branch
from
8bf6acb to
7cb35a8
Compare
Collaborator
|
I see. For the getOne RatingSet will do the needed conversion. That should work. |
rma-bryson
force-pushed
the
bugfix/CDA-46_rating_vertical_datum
branch
from
023247a to
e7d022a
Compare
MikeNeilson
previously approved these changes
Jan 8, 2026
Adding VERTICAL_DATUM constant to the Controllers class for use in the controller implementations. Adding example rating with vertical datum. Adding enum for defining supported vertical datum.
…new `RatingsControllerTestVerticalDatumIT`. Enhance `RatingController` to handle vertical datum conversions.
…sControllerTestVerticalDatumIT` to include additional test cases for datum combinations. Enhance `RatingController` to log vertical datum conversion failures gracefully.
…sControllerTestVerticalDatumIT` to cover additional vertical datum combinations and query scenarios.
…trieval. Adds integration tests.
…to setting default vert datum.
rma-bryson
force-pushed
the
bugfix/CDA-46_rating_vertical_datum
branch
from
5ad96c8 to
4fe9fe3
Compare
…atum location since we test that in its own test class.
…vertical datum is passed in.
Collaborator
|
I think the code changes are done - but I'm not sure what is causing all of the failing tests yet |
Contributor
At least one failing test on the latest schema is due to the recent change Mike P made to actually raise a proper error in one of the timeseries retrieval of location level calls for seasonal data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket:
https://jira.hecdev.net/browse/CDA-46